feat(react-email): better resend integration flow#2647
Merged
gabrielmfern merged 10 commits intocanaryfrom Nov 6, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: d43e15e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
gabrielmfern
requested review from
a team and
vieiralucas
and removed request for
a team and
vieiralucas
gabrielmfern
requested review from
a team and
CarolinaMoraes
and removed request for
a team
commit: |
zenorocha
approved these changes
Nov 6, 2025
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
2 issues found across 2 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="packages/react-email/src/commands/resend-setup.ts">
<violation number="1" location="packages/react-email/src/commands/resend-setup.ts:6">
The application uses a hardcoded encryption key to store the Resend API key, which provides a false sense of security. The key is easily decryptable by anyone with source code access, and the code acknowledges this. This is a misleading and insecure practice for handling sensitive credentials.</violation>
<violation number="2" location="packages/react-email/src/commands/resend-setup.ts:14">
If the user cancels or submits an empty response, this flow will persist an empty/undefined API key, leaving the CLI misconfigured. Please validate the prompt result and abort/set a warning instead of saving invalid values.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Make the Resend setup interactive and secure by prompting for the API key as a password. Removed the CLI apiKey argument, added a replace warning, updated the preview toolbar, and introduced a reset command.
Written for commit d43e15e. Summary will update automatically on new commits.