Skip to content

Keep dt and dd as direct siblings in customer reviews markup (merges into #2681)#2682

Closed
cubic-dev-ai[bot] wants to merge 1 commit intofix/copy-paste-component-compat-issuesfrom
cubic-fix-apps-web-components-customer-reviews-tailwind-tsx-L84-1762976056
Closed

Keep dt and dd as direct siblings in customer reviews markup (merges into #2681)#2682
cubic-dev-ai[bot] wants to merge 1 commit intofix/copy-paste-component-compat-issuesfrom
cubic-fix-apps-web-components-customer-reviews-tailwind-tsx-L84-1762976056

Conversation

@cubic-dev-ai
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot commented Nov 12, 2025

🤖 PR by cubic

This PR addresses the comment in #2681 – fix(web): copy-paste component compatibility issues

File: apps/web/components/customer-reviews/tailwind.tsx
Line: 84
Comment:

Wrapping the rating row in / puts the

inside the preceding
, so the description list no longer has the required dt/dd sibling structure. That breaks HTML semantics that screen readers rely on and can cause the percentage to be skipped. Please restructure so each
and its
remain siblings.

This fix was automatically generated. Please review the changes carefully before merging.


Summary by cubic

Fixed the customer reviews rating list to keep dt and dd as direct siblings. Restores valid dl semantics so screen readers announce the percentage correctly.

  • Bug Fixes
    • Restructured markup: moved Row/Column inside dt; dd now follows as a sibling.
    • Updated both inline-styles.tsx and tailwind.tsx.
    • No visual changes; improves accessibility by preserving description list semantics.

Written for commit e924f8f. Summary will update automatically on new commits.

@cubic-dev-ai cubic-dev-ai bot requested a review from gabrielmfern November 12, 2025 19:34
@vercel
Copy link
Contributor

vercel bot commented Nov 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
react-email Ready Ready Preview Comment Nov 12, 2025 7:35pm
react-email-demo Ready Ready Preview Comment Nov 12, 2025 7:35pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2025

⚠️ No Changeset found

Latest commit: e924f8f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant