fix(tailwind): non-inlined styles getting HTML entities on React 18#2858
Merged
gabrielmfern merged 7 commits intocanaryfrom Jan 20, 2026
Merged
fix(tailwind): non-inlined styles getting HTML entities on React 18#2858gabrielmfern merged 7 commits intocanaryfrom
gabrielmfern merged 7 commits intocanaryfrom
Conversation
🦋 Changeset detectedLatest commit: 5af8933 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
gabrielmfern
changed the title
gabrielmfern
force-pushed
the
fix/react-18-html-entities-in-styles
branch
from
72a5942 to
594a932
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
cubic analysis
No issues found across 1 file
Linked issue analysis
Linked issue: OSS-18: Find a way to make the <Font> component work properly on Windows Outlook
| Status | Acceptance criteria | Notes |
|---|---|---|
| Make the component work properly on Windows Outlook | Preserves raw CSS but no inlining or selector change | |
| ❌ | Avoid using the universal '*' CSS selector (unsupported on Windows Outlook) | No removal or replacement of '*' selector in diffs |
| ❌ | Inline font-family style into all elements (so Windows Outlook gets the font even without '*' support) | No implementation of inlined font-family across elements |
gabrielmfern
requested review from
a team and
joaopcm
and removed request for
a team
joaopcm
approved these changes
Jan 20, 2026
Member
Author
|
@cubic-dev-ai review this |
Contributor
@gabrielmfern I have started the AI code review. It will take a few minutes to complete. |
Contributor
There was a problem hiding this comment.
cubic analysis
No issues found across 2 files
Linked issue analysis
Linked issue: OSS-18: Find a way to make the <Font> component work properly on Windows Outlook
| Status | Acceptance criteria | Notes |
|---|---|---|
| ❌ | Stop relying on the universal (*) CSS selector in the component | No changes to Font or selector usage in diffs |
| ❌ | Apply font-family via inline styles to elements (inline all elements) | No inlining logic or Font component changes present |
| ❌ | Ensure works properly on Windows Outlook (avoid unsupported selectors) | PR only updates Tailwind style injection, not Font compatibility |
cpenned
pushed a commit
that referenced
this pull request
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2841
Summary by cubic
Switched style injection to use dangerouslySetInnerHTML so React 18 doesn’t HTML-encode generated CSS.
Written for commit 5af8933. Summary will update on new commits.