Skip to content

Comments

fix(render): suspense tests#2964

Merged
gabrielmfern merged 2 commits intocanaryfrom
fix/render-tests
Feb 18, 2026
Merged

fix(render): suspense tests#2964
gabrielmfern merged 2 commits intocanaryfrom
fix/render-tests

Conversation

@gabrielmfern
Copy link
Member

@gabrielmfern gabrielmfern commented Feb 18, 2026

Summary by cubic

Stabilized Suspense rendering tests by replacing external fetches with a controlled promise and updating snapshots. This removes network dependency, reduces flakiness, and verifies multibyte content rendering.

  • Bug Fixes
    • Replaced fetch with a 500ms Promise returning HTML.
    • Updated inline snapshots and linted specs in browser and node tests to match final Suspense output.
    • Ensures tests reliably wait for Suspense to resolve before asserting.

Written for commit 3332563. Summary will update on new commits.

@gabrielmfern gabrielmfern requested a review from a team February 18, 2026 14:34
@gabrielmfern gabrielmfern self-assigned this Feb 18, 2026
@gabrielmfern gabrielmfern requested review from joaopcm and removed request for a team February 18, 2026 14:34
@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2026

⚠️ No Changeset found

Latest commit: 3332563

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-email Ready Ready Preview, Comment Feb 18, 2026 2:37pm
react-email-demo Ready Ready Preview, Comment Feb 18, 2026 2:37pm

Request Review

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 18, 2026

Open in StackBlitz

npm i https://pkg.pr.new/resend/react-email/@react-email/render@2964

commit: 3332563

@gabrielmfern gabrielmfern merged commit d2972c9 into canary Feb 18, 2026
17 checks passed
@gabrielmfern gabrielmfern deleted the fix/render-tests branch February 18, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants