Closed
Conversation
Member
Author
|
We're instead opting into using the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing on the work of #527.
After testing out the
5.0.0-canary.0on an existing project I noticed that the approach of using peer dependencies made it so that if the user already had installed the previous version, consequently having@react-email/renderin their lockfile, and then updated, it would keep@react-email/renderin the lockfile for pnpm, npm and bun. This would not happen for new installs, though.If we were to keep it as a peer dependency, we'd need to tell users to either remove things from their lockfile manually, or recreate their lockfile (which they should probably not do).
This pull requests changes it so that we use
devDependenciesinstead, this avoids that problem and will reduce the installed dependencies after upgrading.I tested this with a package prefixed with my name, you can compare installing
gabriel-resend-node@4.7.0, and then installinggabriel-resend-node@5.0.0-canary.0and notice that the lockfile does not include@react-email/renderafter the version change. Here's what you will find with pnpm: