Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
There was a problem hiding this comment.
2 issues found across 2 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="package.json">
<violation number="1" location="package.json:27">
The `tsdown` build command is likely misconfigured and will not produce the output files with the extensions (`.mjs`, `.cjs`, `.d.mts`, `.d.cts`) defined in the `package.json` `exports` map, breaking package resolution.</violation>
<violation number="2" location="package.json:71">
tsdown@0.16.5 requires Node >=20.19.0, but this package still advertises support for Node >=18. Under a Node 18 setup (or even Node 20.18) the new build step fails to load tsdown’s native binding, so `pnpm run build`/`prepublishOnly` will break for contributors using the documented engine range.</violation>
</file>
Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR
vcapretz
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tsup is not actively maintained anymore and recommends that tsdown is used instead, so this migrates to tsdown which React Email has already done a while ago
Summary by cubic
Migrated the build system from tsup to tsdown and updated package exports to use module-aware types (.d.mts/.d.cts) and CJS output (.cjs) for better ESM/CJS interop.
Refactors
Dependencies
Written for commit 348e08b. Summary will update automatically on new commits.