Skip to content

Conversation

@gabrielmfern
Copy link
Member

@gabrielmfern gabrielmfern commented Nov 17, 2025

tsup is not actively maintained anymore and recommends that tsdown is used instead, so this migrates to tsdown which React Email has already done a while ago

image

Summary by cubic

Migrated the build system from tsup to tsdown and updated package exports to use module-aware types (.d.mts/.d.cts) and CJS output (.cjs) for better ESM/CJS interop.

  • Refactors

    • Switched build script to tsdown (esm, cjs, dts).
    • Updated exports: types to .d.mts/.d.cts and CJS default to index.cjs.
  • Dependencies

Written for commit 348e08b. Summary will update automatically on new commits.

@gabrielmfern gabrielmfern self-assigned this Nov 17, 2025
@gabrielmfern gabrielmfern requested a review from a team as a code owner November 17, 2025 13:19
@socket-security
Copy link

socket-security bot commented Nov 17, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedtsdown@​0.16.5981009296100

View full report

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 2 files

Prompt for AI agents (all 2 issues)

Understand the root cause of the following 2 issues and fix them.


<file name="package.json">

<violation number="1" location="package.json:27">
The `tsdown` build command is likely misconfigured and will not produce the output files with the extensions (`.mjs`, `.cjs`, `.d.mts`, `.d.cts`) defined in the `package.json` `exports` map, breaking package resolution.</violation>

<violation number="2" location="package.json:71">
[email protected] requires Node &gt;=20.19.0, but this package still advertises support for Node &gt;=18. Under a Node 18 setup (or even Node 20.18) the new build step fails to load tsdown’s native binding, so `pnpm run build`/`prepublishOnly` will break for contributors using the documented engine range.</violation>
</file>

Reply to cubic to teach it or ask questions. Re-run a review with @cubic-dev-ai review this PR

@gabrielmfern gabrielmfern merged commit 86dbd47 into canary Nov 17, 2025
11 of 12 checks passed
@gabrielmfern gabrielmfern deleted the chore/use-tsdown branch November 17, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants