Skip to content

feat(ci): split script and workflow for e2e test#887

Merged
gabrielmfern merged 4 commits intocanaryfrom
cursor/node-e2e-tests-ci-62fc
Mar 18, 2026
Merged

feat(ci): split script and workflow for e2e test#887
gabrielmfern merged 4 commits intocanaryfrom
cursor/node-e2e-tests-ci-62fc

Conversation

@gabrielmfern
Copy link
Member

@gabrielmfern gabrielmfern commented Mar 18, 2026

Summary

  • exclude integrations/ from the default Vitest scripts and add a dedicated test:e2e command
  • keep test:integrations as an alias to the new e2e command for compatibility
  • add a separate GitHub Actions workflow that builds the package and runs the e2e suite

Testing

  • pnpm test
  • pnpm test:e2e

Slack Thread

Open in Web Open in Cursor 

Summary by cubic

Split integration tests into a dedicated e2e/ suite and a separate CI workflow. Default vitest runs now skip e2e/ so unit tests are faster and E2E runs independently.

  • New Features

    • Add E2E GitHub Actions workflow that builds the package and runs pnpm test:e2e on pushes to main/canary and on PRs.
  • Refactors

    • Rename integrations/ to e2e/ (including Next.js and esbuild fixtures) and update test names.
    • Exclude e2e/ from default vitest commands: test, test:dev, test:record, test:watch.
    • Add pnpm test:e2e; update integration:nextjs to point to e2e/nextjs; update tsconfig.json includes.

Written for commit f84c2c9. Summary will update on new commits.

Slack Thread

Open in Web Open in Cursor 

Summary by cubic

Split integration tests into a dedicated e2e/ suite and added a separate CI workflow. Default vitest runs now skip e2e/ so unit tests are faster and E2E runs independently.

  • New Features

    • Add E2E GitHub Actions workflow that builds the package and runs pnpm test:e2e on pushes to main/canary and on PRs.
  • Refactors

    • Rename integrations/ to e2e/ (including Next.js and esbuild fixtures) and update test names.
    • Exclude e2e/ from default vitest commands: test, test:dev, test:record, test:watch.
    • Add pnpm test:e2e; update integration:nextjs to point to e2e/nextjs; update tsconfig.json includes.

Written for commit 08cedac. Summary will update on new commits.

Co-authored-by: Gabriel Miranda <gabrielmfern@outlook.com>
@gabrielmfern gabrielmfern changed the title Split resend-node integration tests into dedicated e2e workflow feat(ci): split script and workflow for integration test Mar 18, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Co-authored-by: Gabriel Miranda <gabrielmfern@outlook.com>
@cursor cursor bot changed the title feat(ci): split script and workflow for integration test feat(ci): split script and workflow for e2e test Mar 18, 2026
…ts-ci-62fc

Co-authored-by: Gabriel Miranda <gabrielmfern@outlook.com>
@gabrielmfern gabrielmfern marked this pull request as ready for review March 18, 2026 21:06
@gabrielmfern gabrielmfern requested a review from a team as a code owner March 18, 2026 21:06
@gabrielmfern gabrielmfern requested a review from a-carciu March 18, 2026 21:06
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 10 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="package.json">

<violation number="1" location="package.json:40">
P2: The compatibility alias for `test:integrations` was removed; if any CI or developer workflow still calls it, the command will now fail. Re-add the alias to preserve backwards compatibility.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@gabrielmfern gabrielmfern merged commit f86ff17 into canary Mar 18, 2026
13 checks passed
@gabrielmfern gabrielmfern deleted the cursor/node-e2e-tests-ci-62fc branch March 18, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants