chore: clean up post-upgrade warnings - #226
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughRemoves FlowMVIDSL/@BuilderInference across modules, constrains FlowMVIDSL ChangesCore DSL and plugins modernization
Plugins, decorators and utilities
Compose, Essenty, and SavedState updates
Debugger and tooling updates
Metrics tracking refactor and DSL cleanup
Dev/CI/Gradle housekeeping
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17dfc67292
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.devcontainer/devcontainer.json:
- Line 10: The postCreateCommand currently applies a blanket chmod -R 775 which
makes all files executable; update the postCreateCommand to first chown as
before (postCreateCommand), then set permissions by type: use find to set
directories to 775 (find . -type d -exec chmod 775 {} \;), files to 664 (find .
-type f -exec chmod 664 {} \;), and selectively make known script files
executable (e.g. find . -type f -name "*.sh" -or -name "scripts/*" -exec chmod
775 {} \;); replace the single chmod -R 775 invocation with these targeted
commands to avoid marking non-executables as executable while preserving
directory execute bits.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 7a09e777-9373-4609-a7b7-63c158dcffa5
📒 Files selected for processing (82)
.devcontainer/devcontainer.json.gitattributes.github/ci-gradle.properties.github/workflows/junie.yml.gitignore.idea/junie.xml.junie/.onboarding_migrated.junie/memory/errors.md.junie/memory/feedback.md.junie/memory/tasks.mdandroid/src/androidMain/kotlin/pro/respawn/flowmvi/android/view/SubscribeDsl.ktandroid/src/commonMain/kotlin/pro/respawn/flowmvi/android/SubscribeDsl.ktbuildSrc/src/main/kotlin/Config.ktcompose/src/commonMain/kotlin/pro/respawn/flowmvi/compose/dsl/ComposeDsl.ktcompose/src/commonMain/kotlin/pro/respawn/flowmvi/compose/dsl/LocalSubscriberLifecycle.ktcompose/src/commonMain/kotlin/pro/respawn/flowmvi/compose/dsl/SubscribeDsl.ktcompose/src/commonMain/kotlin/pro/respawn/flowmvi/compose/preview/EmptyReceiver.ktcore/src/androidMain/kotlin/pro/respawn/flowmvi/dsl/AndroidDsl.ktcore/src/androidMain/kotlin/pro/respawn/flowmvi/plugins/Deprecated.android.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/api/FlowMVIDSL.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/api/StateReceiver.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/decorator/DecoratorBuilder.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/decorator/DecoratorDsl.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/decorators/BatchIntentsDecorator.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/decorators/ConflateDecorator.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/decorators/DebounceIntentsDecorator.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/decorators/IntentTimeoutDecorator.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/decorators/RetryDecorator.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/dsl/ContainerDsl.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/dsl/LambdaIntent.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/dsl/PipelineDsl.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/dsl/PluginDsl.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/dsl/StateDsl.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/dsl/StoreBuilder.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/dsl/StoreConfigurationBuilder.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/dsl/StoreDsl.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/dsl/StorePluginBuilder.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/dsl/SubscribeDsl.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/impl/plugin/ComposePlugins.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/AsyncCachePlugin.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/AwaitSubscribersPlugin.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/CachePlugin.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/ChildStorePlugin.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/CompositePlugin.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/ConsumeIntentsPlugin.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/DeinitPlugin.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/DisallowRestartPlugin.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/InitPlugin.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/JobManagerPlugin.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/LoggingPlugin.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/RecoverPlugin.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/ReducePlugin.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/TimeTravelPlugin.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/UndoRedoPlugin.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/WhileSubscribedPlugin.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/delegate/StoreDelegatePlugin.ktcore/src/commonMain/kotlin/pro/respawn/flowmvi/util/TypeExt.ktcore/src/jvmMain/kotlin/pro/respawn/flowmvi/dsl/JvmDsl.ktcore/src/nativeMain/kotlin/pro/respawn/flowmvi/plugins/Deprecated.native.ktdebugger/debugger-client/src/commonMain/kotlin/pro/respawn/flowmvi/debugger/client/DebuggerPlugin.ktdebugger/debugger-plugin/src/commonMain/kotlin/pro/respawn/flowmvi/debugger/plugin/DebuggerPlugin.ktdebugger/ideplugin/src/main/resources/LiveTemplates.xmldebugger/server/src/commonMain/kotlin/pro/respawn/flowmvi/debugger/server/DebugServerStore.ktdebugger/server/src/commonMain/kotlin/pro/respawn/flowmvi/debugger/server/di/InjectDsl.ktdebugger/server/src/commonMain/kotlin/pro/respawn/flowmvi/debugger/server/ui/screens/storemetrics/StoreMetricsPage.ktessenty/essenty-compose/src/commonMain/kotlin/pro/respawn/flowmvi/essenty/compose/ContainerDsl.ktessenty/essenty-compose/src/commonMain/kotlin/pro/respawn/flowmvi/essenty/compose/SubscribeDsl.ktessenty/src/commonMain/kotlin/pro/respawn/flowmvi/essenty/dsl/RetainedContainerFactory.ktessenty/src/commonMain/kotlin/pro/respawn/flowmvi/essenty/dsl/RetainedStoreBuilder.ktessenty/src/commonMain/kotlin/pro/respawn/flowmvi/essenty/dsl/RetainedStoreFactory.ktessenty/src/commonMain/kotlin/pro/respawn/flowmvi/essenty/plugins/KeepStatePlugin.ktgradle.propertiesmetrics/src/commonMain/kotlin/pro/respawn/flowmvi/metrics/MetricsCollector.ktmetrics/src/commonMain/kotlin/pro/respawn/flowmvi/metrics/dsl/MetricsDecorator.ktmetrics/src/commonMain/kotlin/pro/respawn/flowmvi/metrics/dsl/MetricsReporterPlugin.ktmetrics/src/jvmTest/kotlin/pro/respawn/flowmvi/metrics/StateMetricsCollectorTest.ktsample/src/commonMain/kotlin/pro/respawn/flowmvi/sample/arch/di/InjectDsl.ktsavedstate/src/androidMain/kotlin/pro/respawn/flowmvi/savedstate/plugins/ParcelizeStatePlugin.ktsavedstate/src/commonMain/kotlin/pro/respawn/flowmvi/savedstate/dsl/TypedSaver.ktsavedstate/src/commonMain/kotlin/pro/respawn/flowmvi/savedstate/plugins/SavedStatePlugin.ktsavedstate/src/commonMain/kotlin/pro/respawn/flowmvi/savedstate/plugins/SerializeStatePlugin.kttest/src/commonMain/kotlin/pro/respawn/flowmvi/test/plugin/PluginTestDsl.kt
💤 Files with no reviewable changes (46)
- .idea/junie.xml
- .gitattributes
- .github/workflows/junie.yml
- test/src/commonMain/kotlin/pro/respawn/flowmvi/test/plugin/PluginTestDsl.kt
- core/src/commonMain/kotlin/pro/respawn/flowmvi/api/StateReceiver.kt
- essenty/essenty-compose/src/commonMain/kotlin/pro/respawn/flowmvi/essenty/compose/ContainerDsl.kt
- core/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/delegate/StoreDelegatePlugin.kt
- core/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/ConsumeIntentsPlugin.kt
- core/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/CompositePlugin.kt
- essenty/src/commonMain/kotlin/pro/respawn/flowmvi/essenty/plugins/KeepStatePlugin.kt
- essenty/essenty-compose/src/commonMain/kotlin/pro/respawn/flowmvi/essenty/compose/SubscribeDsl.kt
- core/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/AsyncCachePlugin.kt
- sample/src/commonMain/kotlin/pro/respawn/flowmvi/sample/arch/di/InjectDsl.kt
- debugger/debugger-plugin/src/commonMain/kotlin/pro/respawn/flowmvi/debugger/plugin/DebuggerPlugin.kt
- core/src/commonMain/kotlin/pro/respawn/flowmvi/decorators/IntentTimeoutDecorator.kt
- savedstate/src/commonMain/kotlin/pro/respawn/flowmvi/savedstate/plugins/SerializeStatePlugin.kt
- core/src/commonMain/kotlin/pro/respawn/flowmvi/decorators/ConflateDecorator.kt
- core/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/ChildStorePlugin.kt
- core/src/commonMain/kotlin/pro/respawn/flowmvi/decorators/BatchIntentsDecorator.kt
- core/src/androidMain/kotlin/pro/respawn/flowmvi/plugins/Deprecated.android.kt
- core/src/commonMain/kotlin/pro/respawn/flowmvi/decorators/RetryDecorator.kt
- debugger/server/src/commonMain/kotlin/pro/respawn/flowmvi/debugger/server/di/InjectDsl.kt
- core/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/AwaitSubscribersPlugin.kt
- core/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/DeinitPlugin.kt
- core/src/commonMain/kotlin/pro/respawn/flowmvi/dsl/PipelineDsl.kt
- core/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/LoggingPlugin.kt
- buildSrc/src/main/kotlin/Config.kt
- compose/src/commonMain/kotlin/pro/respawn/flowmvi/compose/dsl/SubscribeDsl.kt
- core/src/commonMain/kotlin/pro/respawn/flowmvi/decorators/DebounceIntentsDecorator.kt
- core/src/commonMain/kotlin/pro/respawn/flowmvi/decorator/DecoratorBuilder.kt
- core/src/commonMain/kotlin/pro/respawn/flowmvi/decorator/DecoratorDsl.kt
- core/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/UndoRedoPlugin.kt
- core/src/commonMain/kotlin/pro/respawn/flowmvi/dsl/StorePluginBuilder.kt
- android/src/commonMain/kotlin/pro/respawn/flowmvi/android/SubscribeDsl.kt
- compose/src/commonMain/kotlin/pro/respawn/flowmvi/compose/dsl/ComposeDsl.kt
- core/src/nativeMain/kotlin/pro/respawn/flowmvi/plugins/Deprecated.native.kt
- core/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/JobManagerPlugin.kt
- android/src/androidMain/kotlin/pro/respawn/flowmvi/android/view/SubscribeDsl.kt
- core/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/TimeTravelPlugin.kt
- core/src/commonMain/kotlin/pro/respawn/flowmvi/dsl/StoreConfigurationBuilder.kt
- metrics/src/commonMain/kotlin/pro/respawn/flowmvi/metrics/dsl/MetricsDecorator.kt
- core/src/commonMain/kotlin/pro/respawn/flowmvi/plugins/DisallowRestartPlugin.kt
- metrics/src/commonMain/kotlin/pro/respawn/flowmvi/metrics/dsl/MetricsReporterPlugin.kt
- debugger/debugger-client/src/commonMain/kotlin/pro/respawn/flowmvi/debugger/client/DebuggerPlugin.kt
- core/src/commonMain/kotlin/pro/respawn/flowmvi/dsl/StoreBuilder.kt
- savedstate/src/commonMain/kotlin/pro/respawn/flowmvi/savedstate/plugins/SavedStatePlugin.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
master/.builder/plans/metricswarning with a regression test fortimeToFirstStatereset semanticsAccepted Warning Buckets
core/src/commonMain/kotlin/pro/respawn/flowmvi/dsl/StoreDsl.ktINVISIBLE_REFERENCEsuppression warningssavedstate/src/androidMain/kotlin/pro/respawn/flowmvi/savedstate/plugins/ParcelizeStatePlugin.ktbounded-type suppression warnings, intentionally kept to preserve the public API shape for this release2.4.0-RCwith AGP8.13.1R8 metadata warningsurl.parse()and wasm webpack warningsVerification
./gradlew detektFormat./gradlew :metrics:jvmTest --tests "pro.respawn.flowmvi.metrics.StateMetricsCollectorTest"./gradlew allTests./gradlew clean assemble --info --stacktrace --no-configuration-cache --no-build-cache > /tmp/flowmvi_assemble_raw3.log 2>&1Summary by CodeRabbit
Refactor
Chores
Bug Fixes
Tests