-
Notifications
You must be signed in to change notification settings - Fork 20
Add update_uci mode in CLI and test UCI files #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
@timcera - I am putting this here as the fork on your github account does not allow Issues to be posted (happy to put that over there if you prefer). In my opinion, the code in your IOManager class in the I realize that the But even if the preferred way of creatin these child classes is to do them with this type of declaration, IMO if you are going to do validation, you shouldn't have to make the parent class aware of the potential of the child class in order to support the child class via a series of I may be wrong about this, and would be interested in @austinorr opinion or insight. |
|
Using IOManager as a class factory lets you do things like: or or or If instead you setup the conventional, sub-classed IOManager you would have to create a class for every possible combination. |
|
I also changed the way the IOManager class factory is used. Current code you pass in the functions that you want to use for "read_parameters", "read_ts", and "write_ts". When researching class factories I found an example where you passed in a file and the init method chose the correct function to process that file. So that is what the new code does. |
This is a prototype to allow an update of settings ONLY from a UCI into an hdf5 that has already been created with
hsp2 import_uci ....readUCI()