Skip to content

Fix blocked navigation between pages on submission form#3484

Open
lmcnulty wants to merge 1 commit intoresponsible-ai-collaborative:stagingfrom
lmcnulty:fix-blocked-navigation-between-pages-on-submission-form
Open

Fix blocked navigation between pages on submission form#3484
lmcnulty wants to merge 1 commit intoresponsible-ai-collaborative:stagingfrom
lmcnulty:fix-blocked-navigation-between-pages-on-submission-form

Conversation

@lmcnulty
Copy link
Collaborator

@lmcnulty lmcnulty commented Mar 31, 2025

Resolves #3467 (comment)

If you go from e.g. page one to page two, then back, all fields get touched so the unfilled required fields turn red. I think this is the right behavior – it would be annoying if the missing fields were red right from the start, but if you're going back and forth between pages I think it helps to highlight the ones that are missing from earlier.

@codecov
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.32%. Comparing base (e50da71) to head (9e51c4b).
Report is 9 commits behind head on staging.

Additional details and impacted files
@@            Coverage Diff            @@
##           staging    #3484    +/-   ##
=========================================
  Coverage    94.32%   94.32%            
=========================================
  Files           71       71            
  Lines         9080     9080            
  Branches       401      269   -132     
=========================================
  Hits          8565     8565            
- Misses         503      515    +12     
+ Partials        12        0    -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lmcnulty lmcnulty force-pushed the fix-blocked-navigation-between-pages-on-submission-form branch from 16425c2 to 9e51c4b Compare March 31, 2025 19:12
@lmcnulty lmcnulty marked this pull request as ready for review April 1, 2025 15:59
@lmcnulty lmcnulty requested review from a team and pdcp1 and removed request for a team April 1, 2025 15:59
Copy link
Collaborator

@pdcp1 pdcp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for this new behaviour.

Also, it will be better if the required fields are marked in red when the submission fails with "Was not able to create the report, please review the form and try again."

Steps to reproduce it:

  1. https://pr-3484--staging-aiid.netlify.app/apps/submit
  2. Click on Add more info
  3. Click on Submit and confirm
  4. A Was not able to create the report, please review the form and try again. toast is displayed and redirected to Step 1
  5. The required fields should be marked in red

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants