Fix blocked navigation between pages on submission form#3484
Open
lmcnulty wants to merge 1 commit intoresponsible-ai-collaborative:stagingfrom
Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## staging #3484 +/- ##
=========================================
Coverage 94.32% 94.32%
=========================================
Files 71 71
Lines 9080 9080
Branches 401 269 -132
=========================================
Hits 8565 8565
- Misses 503 515 +12
+ Partials 12 0 -12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
16425c2 to
9e51c4b
Compare
pdcp1
requested changes
Apr 1, 2025
Collaborator
pdcp1
left a comment
There was a problem hiding this comment.
Please add tests for this new behaviour.
Also, it will be better if the required fields are marked in red when the submission fails with "Was not able to create the report, please review the form and try again."
Steps to reproduce it:
- https://pr-3484--staging-aiid.netlify.app/apps/submit
- Click on
Add more info - Click on
Submitand confirm - A
Was not able to create the report, please review the form and try again.toast is displayed and redirected to Step 1 - The required fields should be marked in red
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3467 (comment)
If you go from e.g. page one to page two, then back, all fields get touched so the unfilled required fields turn red. I think this is the right behavior – it would be annoying if the missing fields were red right from the start, but if you're going back and forth between pages I think it helps to highlight the ones that are missing from earlier.