fix: align preview layout store key#1478
Merged
manojVivek merged 1 commit intoresponsively-org:mainfrom Mar 23, 2026
Merged
Conversation
manojVivek
approved these changes
Mar 23, 2026
manojVivek
approved these changes
Mar 23, 2026
Collaborator
manojVivek
left a comment
There was a problem hiding this comment.
@Dailin521 Looking great, thank you so much for the contribution!
Collaborator
|
@all-contributors Please add @Dailin521 for code. |
Contributor
|
I've put up a pull request to add @Dailin521! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes the persisted preview layout key mismatch reported in #1458.
Root cause
The electron-store schema defined the layout setting as
ui.previewlayout, while the renderer reads and writesui.previewLayout. Fresh installs therefore missed the schema default for the key the app actually uses, and existing users could lose their saved layout after the schema key is corrected unless the legacy key is migrated.Changes
ui.previewLayoutso the default matches the renderer store accessui.previewlayoutvalue intoui.previewLayoutand removes the legacy keyVerification
npx vitest run src/store/migrations.test.tsnpx eslint src/store/index.ts src/store/migrations.ts src/store/migrations.test.tsnpx tsc --noEmitFixes #1458