Expose timeout for lock via environment variable configuration #786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmm4654
force-pushed
the
master
branch
3 times, most recently
from
df7ef73 to
1f9d5cf
Compare
|
@PatrickTulskie any chance we could get some eyes on this change? 🙏 |
PatrickTulskie
requested changes
May 8, 2024
Contributor
PatrickTulskie
left a comment
PatrickTulskie
left a comment
There was a problem hiding this comment.
Overall good. I'd just like to set the env stuff the way it was instead of the meta programming approach. Calling send usually winds up causing a lot more scrutiny.
pmm4654
force-pushed
the
master
branch
3 times, most recently
from
2b12b0e to
3f2d65c
Compare
Contributor
Author
|
@PatrickTulskie Hey there! I'm just nudging this PR after I made the changes you requested. |
PatrickTulskie
approved these changes
Dec 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose the
timeoutconfiguration option used inResque::Scheduler::Locking::BaseRelated issue: #700