Skip to content

Problem computing minimum time #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lobis wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Problem computing minimum time #101

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1556f45
add check for possible bug with time
lobis Sep 1, 2023
d2ba754
Merge branch 'master' into lobis-time-start
lobis Sep 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/TRestDetectorHitsToSignalProcess.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,8 @@ TRestEvent* TRestDetectorHitsToSignalProcess::ProcessEvent(TRestEvent* inputEven

if (!fReadout) return nullptr;

double minTimeHits = numeric_limits<float>::max();

if (GetVerboseLevel() >= TRestStringOutput::REST_Verbose_Level::REST_Debug) {
cout << "Number of hits : " << fHitsEvent->GetNumberOfHits() << endl;
cout << "--------------------------" << endl;
Expand All @@ -222,6 +224,10 @@ TRestEvent* TRestDetectorHitsToSignalProcess::ProcessEvent(TRestEvent* inputEven
Double_t z = fHitsEvent->GetZ(hit);
Double_t t = fHitsEvent->GetTime(hit);

if (t < minTimeHits) {
minTimeHits = t;
}

if (GetVerboseLevel() >= TRestStringOutput::REST_Verbose_Level::REST_Extreme && hit < 20)
cout << "Hit : " << hit << " x : " << x << " y : " << y << " z : " << z << " t : " << t << endl;

Expand Down Expand Up @@ -278,5 +284,15 @@ TRestEvent* TRestDetectorHitsToSignalProcess::ProcessEvent(TRestEvent* inputEven

if (fSignalEvent->GetNumberOfSignals() == 0) return nullptr;

for (int s = 0; s < fSignalEvent->GetNumberOfSignals(); s++) {
TRestDetectorSignal* signal = fSignalEvent->GetSignal(s);
const double minTime = signal->GetMinTime();
if (minTime < 0) {
cerr << "TRestDetectorHitsToSignalProcess: signal has negative time. This should not happen."
<< endl;
exit(1);
}
}

return fSignalEvent;
}