Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
8484f5b
TRestDetectorReadoutPlane. Added fAxisX and fAxisY. Renamed fPlaneVec…
jgalan Jun 7, 2023
ecb8590
Increasing library version to 2.0
jgalan Jun 7, 2023
5737989
Adding default values
jgalan Jun 7, 2023
cba956e
TRestDetectorReadoutPlane. Adding Setters/Getters
jgalan Jun 7, 2023
949bb89
TRestDetectorReadout. Reading out plane axis Y and Y
jgalan Jun 7, 2023
14b5923
TRestDetectorReadoutPlane. Updating Print information
jgalan Jun 7, 2023
f0af64b
Updating processes to renamed TRestDetectorReadoutPlane::GetNormal() …
jgalan Jun 7, 2023
6ec8fcc
TRestDetectorReadoutPlane::Print. Fixing typo
jgalan Jun 7, 2023
ca7f8a2
Updating readout
jgalan Jun 7, 2023
87f4cb3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 7, 2023
da5c462
TRestDetectorReadout. X and Y plane axis are determined only by norma…
jgalan Jun 7, 2023
6c633c6
Merge branch 'jgalan-readoutplane-update' of github.com:rest-for-phys…
jgalan Jun 7, 2023
6b01b08
fix typos
lobis Jun 8, 2023
507c96d
remove fNModules field
lobis Jun 8, 2023
7fe541f
fix typos
lobis Jun 8, 2023
4f06a6e
Using single parameter height instead of TVector3 cathode position
lobis Jun 8, 2023
af6b85f
simplified initialization
lobis Jun 8, 2023
0368727
remove #pragma region (local IDE settings should not be committed)
lobis Jun 8, 2023
2af0c73
TRestDetectorReadout. Changing the sign of x-axis
jgalan Jun 8, 2023
7a05e4e
Readout updates
jgalan Jun 8, 2023
d003735
Merge branch 'jgalan-readoutplane-update' of github.com:rest-for-phys…
jgalan Jun 8, 2023
d1482dd
Fixing compilation issues
jgalan Jun 8, 2023
00ce0c5
compareFiles.py now validates only numeric values
jgalan Jun 8, 2023
536b3e3
compareFiles.py adding debug output
jgalan Jun 8, 2023
84ab6ec
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 8, 2023
131ee1e
compareFiles.py removing color codes
jgalan Jun 8, 2023
6d3dece
Merge branch 'jgalan-readoutplane-update' of github.com:rest-for-phys…
jgalan Jun 8, 2023
5c30eee
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 8, 2023
e998e63
compareFiles.py fixing typo
jgalan Jun 8, 2023
1e0b296
Merge branch 'jgalan-readoutplane-update' of github.com:rest-for-phys…
jgalan Jun 8, 2023
c50db37
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 8, 2023
7d41f20
updating compareFiles.py
jgalan Jun 8, 2023
7225451
Merge branch 'jgalan-readoutplane-update' of github.com:rest-for-phys…
jgalan Jun 8, 2023
33e2a74
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 8, 2023
f062893
Updating pr-badge.yml
jgalan Jun 8, 2023
0e67550
Merge branch 'jgalan-readoutplane-update' of github.com:rest-for-phys…
jgalan Jun 8, 2023
318ad25
Updating pipeline branch validation
jgalan Jun 8, 2023
1097ce4
use const refs
lobis Jun 9, 2023
3d21748
add TRestDetectorReadoutPlane::UpdateAxes, update how local reference…
lobis Jun 9, 2023
02348eb
Remove redundant TRestDetectorReadoutPlane::GetDistanceTo method
lobis Jun 9, 2023
05cab64
SetHeight with bad parameter raises exception
lobis Jun 9, 2023
97a0e26
TRestDetectorReadout. Adding rotation parameter
jgalan Jun 9, 2023
db710ad
use radians as angular unit
lobis Jun 9, 2023
6462b9b
TRestDetectorReadoutModule::fModuleRotation is now in radians
jgalan Jun 9, 2023
9babbdf
TRestDetectorReadoutModule::fModuleRotation renamed to fRotation
jgalan Jun 9, 2023
18327cb
TRestDetectorReadoutModule. Increasing class version
jgalan Jun 9, 2023
49679cb
renamed some parameters to be coherent with changes in TRestReadoutPlane
lobis Jun 9, 2023
5db58fd
use single parameter for min and max daq ids (daqidrange)
lobis Jun 9, 2023
844841b
remove confusing `GetSizeZ` method (should be called Y?). Single inte…
lobis Jun 9, 2023
da3356b
TRestDetectorReadoutPlane. Increasing class version
jgalan Jun 9, 2023
9d3b51d
TRestDetectorReadoutPlane. Recovering fAxisX and fAxisY
jgalan Jun 11, 2023
e0f4578
remove #pragma region directive
lobis Jun 12, 2023
d1521c2
TRestDetectorReadoutPlane. Fixing a piece of code where module rotati…
jgalan Jun 12, 2023
e78c227
prevent user from setting zero vector as normal
lobis Jun 12, 2023
8e40b13
verify axes and normal are orthonormal reference frame
lobis Jun 12, 2023
cc014aa
handle case when normal is exactly opposite to originalNormal. Add ad…
lobis Jun 12, 2023
2cd0ca7
update axes initialization. Add tests for axes
lobis Jun 12, 2023
65a2f67
TRestDetectorReadout. Adding default values for rotation and chargeCo…
jgalan Jun 13, 2023
95b166f
generateReadout.rml removing units from normal definition
jgalan Jun 13, 2023
a9831e7
TRestDetectorReadout. Charge collection default value removed
jgalan Jun 13, 2023
9a67237
readout/validation.txt Fixing validation axis orientation
jgalan Jun 13, 2023
05dafc9
pipeline/generateReadout.rml adding units
jgalan Jun 13, 2023
5a21b30
methods to go from/to global/local coords
lobis Jun 13, 2023
0fe6b35
rotation is now saved as a value from 0 to 2pi
lobis Jun 13, 2023
b244133
add method to set plane x-axis explicitly. Add validation
lobis Jun 13, 2023
a5159dc
rename originalNormal to zUnit (internal method)
lobis Jun 13, 2023
92da00a
Transferring basic-readouts validation
jgalan Jun 14, 2023
df24542
Merge branch 'jgalan-readoutplane-update' of github.com:rest-for-phys…
jgalan Jun 14, 2023
ee94ffb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 14, 2023
4c9606b
Updating to master validation
jgalan Jun 14, 2023
c912c30
Merge branch 'jgalan-readoutplane-update' of github.com:rest-for-phys…
jgalan Jun 14, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/TRestDetectorReadoutPlane.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -504,7 +504,8 @@ void TRestDetectorReadoutPlane::UpdateAxes() { // idempotent
}

void TRestDetectorReadoutPlane::SetRotation(Double_t radians) {
fRotation = radians;
// sets fRotation modulo 2pi
fRotation = TVector2::Phi_0_2pi(radians);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In principle, why radians would be above 2PI? It could be a way to identify a problem. For example if I do something like plane->SetRotation(180) I will see soon that when transforming to degrees somewhere else in the code, the value is out of range.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add a warning then whenever it goes over 2pi. I think it makes more sense to store rotation between 0 and 2pi in general (not just in this class).

UpdateAxes();
}

Expand Down