-
Notifications
You must be signed in to change notification settings - Fork 4
Readout plane upgrade, readout validation and new library version #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
71 commits
Select commit
Hold shift + click to select a range
8484f5b
TRestDetectorReadoutPlane. Added fAxisX and fAxisY. Renamed fPlaneVec…
jgalan ecb8590
Increasing library version to 2.0
jgalan 5737989
Adding default values
jgalan cba956e
TRestDetectorReadoutPlane. Adding Setters/Getters
jgalan 949bb89
TRestDetectorReadout. Reading out plane axis Y and Y
jgalan 14b5923
TRestDetectorReadoutPlane. Updating Print information
jgalan f0af64b
Updating processes to renamed TRestDetectorReadoutPlane::GetNormal() …
jgalan 6ec8fcc
TRestDetectorReadoutPlane::Print. Fixing typo
jgalan ca7f8a2
Updating readout
jgalan 87f4cb3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] da5c462
TRestDetectorReadout. X and Y plane axis are determined only by norma…
jgalan 6c633c6
Merge branch 'jgalan-readoutplane-update' of github.com:rest-for-phys…
jgalan 6b01b08
fix typos
lobis 507c96d
remove fNModules field
lobis 7fe541f
fix typos
lobis 4f06a6e
Using single parameter height instead of TVector3 cathode position
lobis af6b85f
simplified initialization
lobis 0368727
remove #pragma region (local IDE settings should not be committed)
lobis 2af0c73
TRestDetectorReadout. Changing the sign of x-axis
jgalan 7a05e4e
Readout updates
jgalan d003735
Merge branch 'jgalan-readoutplane-update' of github.com:rest-for-phys…
jgalan d1482dd
Fixing compilation issues
jgalan 00ce0c5
compareFiles.py now validates only numeric values
jgalan 536b3e3
compareFiles.py adding debug output
jgalan 84ab6ec
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 131ee1e
compareFiles.py removing color codes
jgalan 6d3dece
Merge branch 'jgalan-readoutplane-update' of github.com:rest-for-phys…
jgalan 5c30eee
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] e998e63
compareFiles.py fixing typo
jgalan 1e0b296
Merge branch 'jgalan-readoutplane-update' of github.com:rest-for-phys…
jgalan c50db37
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 7d41f20
updating compareFiles.py
jgalan 7225451
Merge branch 'jgalan-readoutplane-update' of github.com:rest-for-phys…
jgalan 33e2a74
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] f062893
Updating pr-badge.yml
jgalan 0e67550
Merge branch 'jgalan-readoutplane-update' of github.com:rest-for-phys…
jgalan 318ad25
Updating pipeline branch validation
jgalan 1097ce4
use const refs
lobis 3d21748
add TRestDetectorReadoutPlane::UpdateAxes, update how local reference…
lobis 02348eb
Remove redundant TRestDetectorReadoutPlane::GetDistanceTo method
lobis 05cab64
SetHeight with bad parameter raises exception
lobis 97a0e26
TRestDetectorReadout. Adding rotation parameter
jgalan db710ad
use radians as angular unit
lobis 6462b9b
TRestDetectorReadoutModule::fModuleRotation is now in radians
jgalan 9babbdf
TRestDetectorReadoutModule::fModuleRotation renamed to fRotation
jgalan 18327cb
TRestDetectorReadoutModule. Increasing class version
jgalan 49679cb
renamed some parameters to be coherent with changes in TRestReadoutPlane
lobis 5db58fd
use single parameter for min and max daq ids (daqidrange)
lobis 844841b
remove confusing `GetSizeZ` method (should be called Y?). Single inte…
lobis da3356b
TRestDetectorReadoutPlane. Increasing class version
jgalan 9d3b51d
TRestDetectorReadoutPlane. Recovering fAxisX and fAxisY
jgalan e0f4578
remove #pragma region directive
lobis d1521c2
TRestDetectorReadoutPlane. Fixing a piece of code where module rotati…
jgalan e78c227
prevent user from setting zero vector as normal
lobis 8e40b13
verify axes and normal are orthonormal reference frame
lobis cc014aa
handle case when normal is exactly opposite to originalNormal. Add ad…
lobis 2cd0ca7
update axes initialization. Add tests for axes
lobis 65a2f67
TRestDetectorReadout. Adding default values for rotation and chargeCo…
jgalan 95b166f
generateReadout.rml removing units from normal definition
jgalan a9831e7
TRestDetectorReadout. Charge collection default value removed
jgalan 9a67237
readout/validation.txt Fixing validation axis orientation
jgalan 05dafc9
pipeline/generateReadout.rml adding units
jgalan 5a21b30
methods to go from/to global/local coords
lobis 0fe6b35
rotation is now saved as a value from 0 to 2pi
lobis b244133
add method to set plane x-axis explicitly. Add validation
lobis a5159dc
rename originalNormal to zUnit (internal method)
lobis 92da00a
Transferring basic-readouts validation
jgalan df24542
Merge branch 'jgalan-readoutplane-update' of github.com:rest-for-phys…
jgalan ee94ffb
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 4c9606b
Updating to master validation
jgalan c912c30
Merge branch 'jgalan-readoutplane-update' of github.com:rest-for-phys…
jgalan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In principle, why radians would be above 2PI? It could be a way to identify a problem. For example if I do something like
plane->SetRotation(180)I will see soon that when transforming to degrees somewhere else in the code, the value is out of range.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add a warning then whenever it goes over 2pi. I think it makes more sense to store rotation between 0 and 2pi in general (not just in this class).