Skip to content

Conversation

@AlvaroEzq
Copy link
Contributor

@AlvaroEzq AlvaroEzq commented Jul 22, 2025

AlvaroEzq Large: 588 Powered by Pull Request Badge

Fix some bugs of TRestDataSetGainMap:

  • When moduleDefinitionCut was not set, TRestDataSetGainMap::CalibrateDataSet failed. Now, set the moduleDefinitionCut to 1 (all events accepted) and also check if its value is empty to set it back to 1.
  • Automatic naming of output dataset in TRestDataSetGainMap::CalibrateDataSet was wrong. The . before the root extension was missing.
  • Fix documentation

Add new feature:

  • Now it accepts as dataSetFileName a run file or a file pattern containing several run files. In this new case, it generates the dataset on the fly to get the spectrums needed.
  • Add the REST_RefitGainMap macro for a better experience when refitting the peaks manually.

Other changes:

  • Add new function TRestTools:GetObservablesInString
  • Fix TRestTools:isDataSet to return false if the input file doesn't exist (before it used to crash)

@AlvaroEzq AlvaroEzq requested a review from nkx111 as a code owner July 22, 2025 11:25
@AlvaroEzq AlvaroEzq merged commit 43a4c1d into master Jul 24, 2025
126 of 127 checks passed
@AlvaroEzq AlvaroEzq deleted the aezq_gmImprovements branch July 24, 2025 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants