-
Notifications
You must be signed in to change notification settings - Fork 6
Differentiate between identical volumes #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…ionOnGDMLVolume and GetPositionOnGDMLSurface
for more information, see https://pre-commit.ci
Contributor
Author
|
The last commit fixes #143 |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Anakintana
approved these changes
Jan 22, 2026
lobis
approved these changes
Jan 22, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differentiation between identical volumes
Changes to be able to differentiate between identical volumes. In particular there are two cases where the volumes need further filtering:
The particular physical volume where the step of the Geant4 simulation is happening, can be obtain using the G4VTouchable. This should be done for every part of the simulation where any kind of physical volume given by the user is used. These are:
Primary generator fixes
I also took the oportunity of this PR to fix a couple of problems with the primary generator from gdml volumes:
Important
The changes of PR rest-for-physics/geant4lib#146 are needed.