[Ingest] Use bilrost encoding for ingestion message #4113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2025
Summary: Switch to bilrost encoding
AhmedSoliman
approved these changes
Dec 17, 2025
Contributor
AhmedSoliman
left a comment
AhmedSoliman
left a comment
There was a problem hiding this comment.
@muhamadazmy Thanks for the quick turnaround.
| #[derive(Debug, serde::Serialize, serde::Deserialize)] | ||
| #[derive(Debug, bilrost::Message)] | ||
| pub struct IngestRequest { | ||
| #[bilrost(tag(1), encoding(ArcedSlice<packed>))] |
Contributor
There was a problem hiding this comment.
Nice. Shame that Payloads is unpacked though.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Ingest] Use bilrost encoding for ingestion message
Summary:
Switch to bilrost encoding
Stack created with Sapling. Best reviewed with ReviewStack.
Shuffler#4024IngestionClientfor invocation and state mgmt #3980ingestion-client#3975