[RocksDB] Allow for WriteBatch buffer reuse after commit#4360
Draft
AhmedSoliman wants to merge 2 commits intomainfrom
Draft
[RocksDB] Allow for WriteBatch buffer reuse after commit#4360AhmedSoliman wants to merge 2 commits intomainfrom
AhmedSoliman wants to merge 2 commits intomainfrom
Conversation
…pped the message This also adds a new metric/counter to count the bytes we dropped after receiving due to a lossy service.
Test Results 7 files + 2 7 suites +2 2m 45s ⏱️ + 1m 45s Results for commit 25b46aa. ± Comparison against base commit 42114b8. This pull request removes 26 and adds 47 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with Sapling. Best reviewed with ReviewStack.