Add HTTP/2 multiplexed connection with concurrency control#4486
Open
muhamadazmy wants to merge 1 commit intorestatedev:mainfrom
Open
Add HTTP/2 multiplexed connection with concurrency control#4486muhamadazmy wants to merge 1 commit intorestatedev:mainfrom
muhamadazmy wants to merge 1 commit intorestatedev:mainfrom
Conversation
muhamadazmy
force-pushed
the
pr4486
branch
2 times, most recently
from
1aeb48e to
bf72b8d
Compare
muhamadazmy
force-pushed
the
pr4486
branch
3 times, most recently
from
48d94ea to
63d9344
Compare
|
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit in Settings → Usage. Once credits are available, reopen this pull request to trigger a review. |
muhamadazmy
force-pushed
the
pr4486
branch
2 times, most recently
from
7bb2e71 to
79a6c9a
Compare
Merged
muhamadazmy
force-pushed
the
pr4486
branch
6 times, most recently
from
d3b88de to
c9a1dcd
Compare
tillrohrmann
requested changes
Mar 30, 2026
Contributor
tillrohrmann
left a comment
tillrohrmann
left a comment
There was a problem hiding this comment.
Thanks a lot for creating this PR @muhamadazmy. It's quite some piece of work with the lock free connection sharing which is really cool. I left a few questions regarding the chosen memory orderings and about a possible problem when registering waiters on a closing connection which might cause those waiters to get stuck.
muhamadazmy
force-pushed
the
pr4486
branch
4 times, most recently
from
66f4215 to
b303703
Compare
## Summary - Introduce Connection<C>, a Tower Service-based HTTP/2 connection that multiplexes requests over a single H2 session with semaphore-backed concurrency control - Add TcpConnector service and ConnectionInfo/IntoConnectionInfo abstractions for URI-based TCP connection establishment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add HTTP/2 multiplexed connection with concurrency control
Summary
Stack created with Sapling. Best reviewed with ReviewStack.