[Service-Client] H2 Pool integation and usage in service client#4493
Open
muhamadazmy wants to merge 3 commits intorestatedev:mainfrom
Open
[Service-Client] H2 Pool integation and usage in service client#4493muhamadazmy wants to merge 3 commits intorestatedev:mainfrom
muhamadazmy wants to merge 3 commits intorestatedev:mainfrom
Conversation
This was referenced Mar 16, 2026
muhamadazmy
force-pushed
the
pr4493
branch
4 times, most recently
from
eb9b4ca to
a7b78b3
Compare
muhamadazmy
changed the title
|
Code review is billed via overage credits. To resume reviews, an organization admin can raise the monthly limit in Settings → Usage. Once credits are available, reopen this pull request to trigger a review. |
muhamadazmy
force-pushed
the
pr4493
branch
2 times, most recently
from
01461e0 to
5857bf0
Compare
muhamadazmy
changed the title
Merged
muhamadazmy
force-pushed
the
pr4493
branch
6 times, most recently
from
71da9b7 to
2e8b9fc
Compare
Contributor
tillrohrmann
left a comment
tillrohrmann
left a comment
There was a problem hiding this comment.
Thanks for integrating the connection pool into the HttpClient @muhamadazmy. I left a few minor comments. Did you run any benchmarks to see whether the new connection pool has any performance implications?
Comment on lines
+500
to
503
| //todo: this is a temp clone to test | ||
| Self::WaitingHeaders { | ||
| join_handle: AbortOnDropHandle::new(tokio::task::spawn(client.call(req))), | ||
| } |
Contributor
There was a problem hiding this comment.
What are we testing here? Should this become part of main if it's for testing?
Comment on lines
75
to
77
| /// Client when HTTP2 was specifically requested - for cleartext, we use h2c, | ||
| /// and for HTTPS, we will fail unless the ALPN supports h2. | ||
| /// In practice, at discovery time we never force h2 for HTTPS. |
| /// type complexity for higher layer | ||
| #[pin_project::pin_project] | ||
| pub struct ResponseBody { | ||
| #[pin] |
Contributor
There was a problem hiding this comment.
Why is pin needed here? Is Incoming !Unpin?
| /// **NOTE**: Setting this value to None (default) users the default | ||
| /// recommended value from HTTP2 specs | ||
| pub initial_max_send_streams: Option<usize>, | ||
| pub initial_max_send_streams: Option<u32>, |
Contributor
There was a problem hiding this comment.
Is Some(0) a valid value here?
crates/types/src/config/http.rs
Outdated
| /// If the ping is not acknowledged within the timeout, the connection will | ||
| /// be closed. | ||
| /// | ||
| /// Only meaningful when `keep_alive_interval` is `Some`. Defaults to 20 s. |
Contributor
There was a problem hiding this comment.
What is keep_alive_interval referring to?
muhamadazmy
force-pushed
the
pr4493
branch
2 times, most recently
from
44dd0bf to
3862f24
Compare
muhamadazmy
force-pushed
the
pr4493
branch
2 times, most recently
from
e49e78d to
43b08ad
Compare
## Summary - Introduce Connection<C>, a Tower Service-based HTTP/2 connection that multiplexes requests over a single H2 session with semaphore-backed concurrency control - Add TcpConnector service and ConnectionInfo/IntoConnectionInfo abstractions for URI-based TCP connection establishment
## Summary - Add AuthorityPool<C> that manages multiple H2 connections to a single authority (scheme+host+port), creating connections on demand when streams are exhausted and evicting failed ones - Add Pool<C> that routes requests to the correct AuthorityPool via a DashMap<ConnectionInfo, AuthorityPool<C>> - Add PoolBuilder with configurable max_connections and init_max_streams per authority
- This PR finally enable using of the new H2 pool in the http service client. Fixes restatedev#4451
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Service-Client] H2 Pool integation and usage in service client
Fixes #4451
Stack created with Sapling. Best reviewed with ReviewStack.