Add thread-local string interner for ReString#4540
Draft
AhmedSoliman wants to merge 1 commit intomainfrom
Draft
Conversation
Introduces InternedReString, a wrapper around ReString that deduplicates long strings via a per-thread HashSet. Strings longer than size_of::<String>() are stored as Arc<str> and looked up on construction and during deserialization (serde and bilrost), so repeated values share a single heap allocation. Short strings are stored inline and bypass the interner entirely. The bilrost decode path is optimized with a fast path for contiguous buffers: when chunk() covers the full string, we read directly as &str and query the interner without allocating a temporary buffer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces InternedReString, a wrapper around ReString that deduplicates
long strings via a per-thread HashSet. Strings longer than size_of::()
are stored as Arc and looked up on construction and during deserialization
(serde and bilrost), so repeated values share a single heap allocation.
Short strings are stored inline and bypass the interner entirely.
The bilrost decode path is optimized with a fast path for contiguous buffers:
when chunk() covers the full string, we read directly as &str and query the
interner without allocating a temporary buffer.