Add rocksdb_readoptions_set_table_filter to C API#20
Open
pcholakov wants to merge 1 commit intorestatedev:restate-10.9.1from
Open
Add rocksdb_readoptions_set_table_filter to C API#20pcholakov wants to merge 1 commit intorestatedev:restate-10.9.1from
pcholakov wants to merge 1 commit intorestatedev:restate-10.9.1from
Conversation
pcholakov
force-pushed
the
table-filter
branch
from
0b0f15e to
ceb4f97
Compare
Expose ReadOptions::table_filter through the C API. The new function accepts a state pointer, a filter callback, and a destructor. The implementation wraps these into a std::function lambda assigned to rep.table_filter, using shared_ptr for lifetime management.
pcholakov
force-pushed
the
table-filter
branch
from
ceb4f97 to
1667e3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReadOptions::table_filterthrough the C API viarocksdb_readoptions_set_table_filterstatepointer, filter callback, and destructor following the established pattern (e.g.rocksdb_compactionfilter_create)shared_ptr<void>to manage callback lifetime through thestd::functionlambdaTest plan