-
Notifications
You must be signed in to change notification settings - Fork 15
Support non-deterministic codecs via PayloadOptions #122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
Hey @ciricc, I think there was a misunderstanding in our initial discussion. As said here: #116 (comment) |
|
Hey @ciricc can you update this PR? |
Yes, i'll do that soon |
|
I published the shared core 0.7.0, you can use that |
700105a to
7a76235
Compare
WithDisablePayloadChecks() option to disable non-determinism checks for payloads during replay.|
Changes
Added test suite for E2E testing (without changing the sdk-test-suite). |
slinkydeveloper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor bits, and it looks good!
|
Thank you so much for your PR! |
Motivation
protojson.Marshaldoes not guarantee deterministic output (map key ordering, etc.),causing panics during replay when payload comparisons fail.
Changes
VmOptionsto internal protoNonDeterministicChecksOption::PayloadChecksDisabledWithDisablePayloadChecks()method toserver.RestateUsage
restate := server.NewRestate().
WithDisablePayloadChecks().
Bind(...)
Fixes #116