Add HTTP/1.1 handler support to Node.js endpoint#643
Open
Conversation
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
Signed-off-by: Nik Nasr <nik@restate.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some Node.js frameworks and libraries only accept HTTP/1.1 request listeners, so integrating Restate with them means going through the fetch handler and converting it back to a Node listener.
This isn't strictly needed, that conversion works fin, but having a native HTTP/1.1 handler makes those integrations a bit more straightforward. Totally fine if we prefer not to expand the API surface.
http1Handler()andhandler()methods toRestateEndpoint, alongside the existinghttp2Handler().http1Handler()returns a handler typed forhttp.createServer(). It defaults toREQUEST_RESPONSEprotocol mode; pass{ bidirectional: true }to useBIDI_STREAM.handler()returns an overloaded callable that auto-detects HTTP version per request: HTTP/2+ uses BIDI_STREAM, HTTP/1.1 uses REQUEST_RESPONSE by default. The bidirectional option is tri-state: true forces BIDI_STREAM for all, false forces REQUEST_RESPONSE for all, undefined auto-detects.createEndpointHandler()now returns the unifiedhandler(), accepting a new NodeEndpointOptions type with the bidirectional option.nodeHttp1Handler/nodeHttp2Handlertyped wrappers over a sharednodeHandlerImpl, separating HTTP transport types from protocol mode.HTTP/1.1example (greeter_http1.ts) and integration tests covering both request-response and bidirectional modes using testcontainers withuse_http_11: true.