Skip to content

Conversation

@thboileau
Copy link
Contributor

@thboileau thboileau commented Dec 20, 2024

The aim

When checking GWT edition, noticed several issues:

  • getting the value of annotations (like @Put("json")) - regression introduced with JDK 11
  • fixed the media type (moved from application/x-java-serialized-object+gwt to text/x-gwt-rpc
  • dropped JRE emulations

Check-list

  • PR size
    • Under 300 lines ✅
    • Can't be split without complicating the process even more
  • Tests
    • Added
    • Not applicable (tested manually)
  • Doc
    • Added (later)
    • Not applicable
  • Reviewer
    • Asked for a review
    • Added label DO NOT REVIEW

@thboileau thboileau merged commit 85b9c66 into 2.5 Dec 20, 2024
1 check passed
@thboileau thboileau deleted the 2.5__1435_upgrade_gwt_2-11 branch December 20, 2024 21:32
Copy link
Collaborator

@jlouvel jlouvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @thboileau

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants