Skip to content

Fix: add patch to fix a GstStructure unref in GstAudioAggregator #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neodesys merged 1 commit into from
Jun 18, 2025
Merged

Fix: add patch to fix a GstStructure unref in GstAudioAggregator #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docker/build-gstreamer/compile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ git apply /compile-patch/0001-compositor-add-rounded-corners-property-for-sink-p
git apply /compile-patch/0001-pad-Check-data-NULL-ness-when-probes-are-stopped-fixed-in-1.24.8.patch
git apply /compile-patch/0001-Reduce-logs-verbosity-in-webrtcbin-when-a-FEC-decode.patch
git apply /compile-patch/0001-glvideomixer-update-API-to-be-compatible-with-versio.patch
git apply /compile-patch/0001-GstAudioAggregator-fix-structure-unref.patch

# This is needed for other plugins to be built properly
ninja -C build install
Expand Down
27 changes: 27 additions & 0 deletions docker/build-gstreamer/patch/0001-GstAudioAggregator-fix-structure-unref.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
From 4c5779845cb8dedf0797b78c382f8f0f8b0d19e2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Le=20Page?= <llepage@igalia.com>
Date: Wed, 18 Jun 2025 18:46:56 +0200
Subject: [PATCH] GstAudioAggregator: fix structure unref in peek_next_sample

The GstStructure attached to the audio sample in peek_next_sample() was
freed prematurely before usage as gst_sample_new() is taking full
ownership on it.
---
.../gst-plugins-base/gst-libs/gst/audio/gstaudioaggregator.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/subprojects/gst-plugins-base/gst-libs/gst/audio/gstaudioaggregator.c b/subprojects/gst-plugins-base/gst-libs/gst/audio/gstaudioaggregator.c
index d967a3295d..811e5e8a43 100644
--- a/subprojects/gst-plugins-base/gst-libs/gst/audio/gstaudioaggregator.c
+++ b/subprojects/gst-plugins-base/gst-libs/gst/audio/gstaudioaggregator.c
@@ -2188,7 +2188,6 @@ gst_audio_aggregator_peek_next_sample (GstAggregator * agg,

sample = gst_sample_new (pad->priv->buffer, caps, &aggpad->segment, info);
gst_caps_unref (caps);
- gst_structure_free (info);
}

return sample;
--
2.43.0