always ring the bell after taking the shot#413
Merged
N-R-K merged 1 commit intoresurrecting-open-source-projects:masterfrom May 5, 2025
Merged
always ring the bell after taking the shot#413N-R-K merged 1 commit intoresurrecting-open-source-projects:masterfrom
N-R-K merged 1 commit intoresurrecting-open-source-projects:masterfrom
Conversation
currently it only rings it after certain cases but not all. move the bell ringing outside of grab mode specific code and into main() where it will be consistently rang in case of a successful capture regardless of grab mode. Fixes: resurrecting-open-source-projects#412
N-R-K
merged commit 8acd7a2
into
resurrecting-open-source-projects:master
17 of 18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently it only rings it after certain cases but not all. move the bell ringing outside of grab mode specific code and into main() where it will be consistently rang in case of a successful capture regardless of grab mode.
Fixes: #412