Allow win naming conventions in ENUM! and STRUCT!#991
Open
Madoshakalaka wants to merge 2 commits intoretep998:0.3from
Open
Allow win naming conventions in ENUM! and STRUCT!#991Madoshakalaka wants to merge 2 commits intoretep998:0.3from
Madoshakalaka wants to merge 2 commits intoretep998:0.3from
Conversation
Allow win naming conventions in ENUM! and STRUCT!
Madoshakalaka
commented
May 19, 2021
Comment on lines
+359
to
360
| #[allow(non_snake_case)] | ||
| macro_rules! ENUM { |
Author
There was a problem hiding this comment.
macro names should be in lowercase too. maybe it's more fitting to name this macro win_enum or c_enum
Madoshakalaka
commented
May 19, 2021
Comment on lines
+390
to
391
| #[allow(non_snake_case)] | ||
| macro_rules! STRUCT { |
Author
There was a problem hiding this comment.
same, could name it win_struct or c_struct?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the ENUM! and STRUCT! macros generate a lot of lint warnings, here's an example taken from some code I am writing:
cargo buildoutput:This PR adds
#[allow(non_camel_case_types)],#[allow(non_upper_case_globals)]and#[allow(non_snake_case)]to suppresstypeconstand struct field naming conflicts respectively.