fix: update artifact type for goreleaser v2#302
Merged
Conversation
GoReleaser v2 renamed the artifact type from "Brew Tap" to "Homebrew Formula", causing the wheel build to fail with a KeyError when looking for description/license metadata.
Owner
Author
|
@0xDEC0DE can you have a look? |
0xDEC0DE
reviewed
Jan 29, 2026
| # Burn a pass through the list to steal some useful bits from the Brew config | ||
| for artifact in self.artifacts: | ||
| if artifact["type"] == "Brew Tap": | ||
| if artifact["type"] == "Homebrew Formula": |
Contributor
There was a problem hiding this comment.
This has always in a sense been cheating, and "stealing" info from the GoReleaser configs, so that you could have to update them in more than one place.
Originally, I avoided using the internal_type item in the JSON under the auspices of avoiding internal implementation details that might randomly change out from under me, but it's beginning to look like those are in fact some of the most stable items in here. Might want to switch to using them instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GoReleaser v2 renamed the artifact type from "Brew Tap" to "Homebrew Formula", causing the wheel build to fail with a KeyError when looking for description/license metadata.