refactor: swap out git CLI with go-git#306
Draft
0xDEC0DE wants to merge 3 commits intoretr0h:mainfrom
Draft
Conversation
Contributor
Author
|
This absolutely does not work. Blobless clones from go-git are non-functional still. We can sit on this and retry periodically as the upstream library changes, and continue/finish when it finally gets there. |
Contributor
Author
|
Oh, and this will need a proper interface to go-git so it can be mocked out |
Moves the existence check into the Git helper and return a true/false, rather than leaving it up to the caller. This should ease future work.
This removes the indirect requirement for shell tools to be installed. Fixes: Issue retr0h#72
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the indirect requirement for shell tools to be installed.
Fixes: Issue #72