fix(lsp): prevent LspOrganize command duplication and add safety guards #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the legacy `.meowg1k/config.yaml` with the new root `.meowg1k.yml` to align with the latest tool version. This change centralizes and significantly enhances the AI development assistant's capabilities. The new configuration introduces comprehensive, project-specific prompts for Lua code review, plugin development, refactoring, and documentation. It also defines multiple Gemini model profiles (fast, smart, embeddings) and improves the `ask`, `commit`, and `pullRequest` workflows for meowvim development.
Improves the out-of-the-box experience for TypeScript and JavaScript by refining LSP, completion, and formatting configurations. Key changes include: - **tsserver**: - Adds an "Organize Imports" feature, available via `<leader>xo` and the `:LspOrganize` command. - Enables extensive inlay hints for parameter names, variable types, and more, providing richer inline context. - Disables the built-in LSP formatter, deferring to `conform.nvim` to respect project-local Prettier configurations. - Enables `updateImportsOnFileMove` for better refactoring support. - **nvim-cmp**: - Adds new completion sources for Lua (`nvim_lua`) and the command line (`cmdline`), improving the editing experience beyond just TS/JS. - Enhances the completion menu with source-specific icons for better readability. - **conform.nvim**: - Removes hardcoded `--tab-width` for Prettier, allowing it to use the settings from a project's `.prettierrc` file.
Co-authored-by: retran <[email protected]>
Copilot
AI
changed the title
[WIP] Address feedback from PR #30 on TypeScript/Lua enhancements
fix(lsp): prevent LspOrganize command duplication on multiple TS/JS buffers
Oct 29, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a command duplication issue in the TypeScript language server configuration by moving the LspOrganize command creation from the on_attach callback to a global scope.
Key Changes:
- Moved
LspOrganizecommand creation outside of theon_attachcallback to prevent duplication warnings - The command is now created once globally before the TypeScript LSP setup, rather than being recreated for each buffer attachment
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
@copilot adress review comments |
Co-authored-by: retran <[email protected]>
Copilot
AI
changed the title
fix(lsp): prevent LspOrganize command duplication on multiple TS/JS buffers
fix(lsp): prevent LspOrganize command duplication and add safety guards
Oct 29, 2025
retran
requested review from
Copilot
and removed request for
Copilot and
retran
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
@copilot address review comments |
Co-authored-by: retran <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
@copilot address review comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bufnptypo tobufnrfor consistency with the rest of the fileAll review feedback has been addressed:
bufnptobufnr✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.