Velocity's varint reading/writing optimizations #1070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix ServerVersion.getById for ClientVersion.V_1_9_1
booky10
requested changes
Nov 27, 2024
Collaborator
booky10
left a comment
booky10
left a comment
There was a problem hiding this comment.
Additionally, it may also make sense to move this varint read/write implementation to the ByteBufOperator implementations to prevent way too many getter calls
api/src/main/java/com/github/retrooper/packetevents/netty/buffer/ByteBufHelper.java
Outdated
Show resolved
Hide resolved
booky10
changed the title
Contributor
Author
|
...why did this commit here
|
ShadowOfHeaven-Me
force-pushed
the
2.0
branch
2 times, most recently
from
21f7324 to
94d4d80
Compare
Owner
|
It appears that this PR has some conflicts that are unresolved. Do we still intend on integrating this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically it. Not sure why I can't disregard my the previous pr changes, but whatever, the current origin should have the exact same code