Added WrapperPlayServerSculkVibrationSignal#380
Added WrapperPlayServerSculkVibrationSignal#380NoJokeFNA wants to merge 6 commits intoretrooper:2.0from
Conversation
retrooper
left a comment
retrooper
left a comment
There was a problem hiding this comment.
Instead of a string identifier, maybe see if the ResourceLocation can be used. PacketWrapper#readResourceLocation or readIdentifier, is what it might be called in the wrappers.
|
I will test it today or tomorrow. |
…estinationIdentifier`
|
Does it work on 1.8? |
|
No. Sculks were introduced on newer versions. |
retrooper
left a comment
retrooper
left a comment
There was a problem hiding this comment.
On wiki.vg it says the "destination" (field after the destination identifier) can either be a VarInt ENTITY ID or a Long encoded block position. So this code might not always work? https://wiki.vg/Protocol#Sculk_Vibration_Signal
|
Yea but I don't know under which circumstances. I tested it for a few time and haven't received any errors or such. |
|
Have you checked minecraft's vanilla code? |
|
I'll check. |
|
Depends on the identifier. I think the identifier can either be "minecraft:entity" or "minecraft:block" according to vanilla code. |
|
But I'd say do some debugging too. |
|
Alright, will do it later |
2 participants
https://wiki.vg/Protocol#Sculk_Vibration_Signal
Tested Server-Versions: 1.18.2