Fixed: item 'ondek meer genres' missing in NPO's 'TV shows'#1884
Merged
basrieter merged 1 commit intoretrospect-addon:masterfrom Feb 7, 2025
Merged
Fixed: item 'ondek meer genres' missing in NPO's 'TV shows'#1884basrieter merged 1 commit intoretrospect-addon:masterfrom
basrieter merged 1 commit intoretrospect-addon:masterfrom
Conversation
|
basrieter
approved these changes
Feb 7, 2025
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functional description
Adds an entry 'ondek meer genres' to the genres currently display in menu NPO -> 'TV Shows', allowing acces to more catergories and sub-categories, and ultimately a lot of additional programmes.
Reasoning
This entry, althought present on NPO's website, was missing in the channel's menu. Without it, a large number of programmes would only be available by doing a search.
Technical description
Allowed an extra page_type
DYNAMIC_PAGEand used an already exisiting (but unused?) parser to parse these pages.Tasks & Activities
Don't think so. To me at least, it works quite satisfactory.