Fixed: Run search inline to prevent Kodi race condition#1941
Merged
basrieter merged 1 commit intoretrospect-addon:masterfrom Mar 7, 2026
Merged
Fixed: Run search inline to prevent Kodi race condition#1941basrieter merged 1 commit intoretrospect-addon:masterfrom
basrieter merged 1 commit intoretrospect-addon:masterfrom
Conversation
Container.Update triggers a separate plugin instance that races with endOfDirectory. Slow API responses cause Kodi to render the stale search-history page instead of the actual results. Run the search directly in the keyboard branch so results are rendered in the same plugin instance. Known issue: empty needle is passed through, so refreshing search results triggers the keyboard pop-up instead of re-running the query. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Olliver Schinagl <oliver@schinagl.nl>
|
Collaborator
|
There was something with searching and caching within Retrospect. But let's just try this. |
basrieter
added a commit
that referenced
this pull request
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Container.Update triggers a separate plugin instance that races with endOfDirectory. Slow API responses cause Kodi to render the stale search-history page instead of the actual results.
Run the search directly in the keyboard branch so results are rendered in the same plugin instance.
Known issue: empty needle is passed through, so refreshing search results triggers the keyboard pop-up instead of re-running the query.