Closed
Conversation
Co-authored-by: @gucl-mu
Co-authored-by: @gucl-mu
Co-authored-by: @gucl-mu
this commit deletes full stops. full stops are only provided, if the caption contains more than one sentence. Refs music-encoding#1635
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
…on-to-verovio-and-listings guidelines: add captions to verovio and listings for chapter 1–3
…e-examples guidelines: fix tablature examples dots
guidelines: fix ossia section
…termark schema: remove watermark's membership in msInline
This PR changes the content model of respStmt to - make it more TEI-like ( resp+, nameLike+ or nameLike+, resp+); - clarify use of respStmt This is a backward-compatibility breaking change. However, if the existing model of respStmt has been used to contain only names, each with a role attribute, then that usage can easily be converted via XSLT to the new model; that is, the content of the role attribute can be placed in a new resp element.
see from music-encoding#1365 (comment) Co-authored-by: @pe-ro
…spStmt schema: revise model of `<respStmt>`
When generate_examples.py was migrated to use Python's pathlib in 4ee9761, the suffixes of generated example images (in assets/images/GeneratedImages) went from being ".mei.svg" to just ".svg" because Path.with_suffix() replaces, rather than appends to, the existing suffix. This caused references to those files on the site to be broken. This change alters the xslt generating the image link references to use .svg as well, restoring those links. Refs music-encoding#1458
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
…step-1 schema: develop watermark (Step 1)
utils: fix example images being created with the wrong suffix
As the schema is valid and correctly transforms in the current toolchain, these checks should not throw errors but warn about future problems. Moreover, it allows to implement an automatic check fir this.
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
Co-authored-by: Stefan Münnich <stefan.muennich@unibas.ch>
rettinghaus
force-pushed
the
ftr/purification-precheck
branch
2 times, most recently
from
f74e633 to
9b11c06
Compare
rettinghaus
force-pushed
the
ftr/purification-precheck
branch
from
9b11c06 to
d73c890
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.