-
Notifications
You must be signed in to change notification settings - Fork 119
(QIF) mapping ubs-ch-fr: better normalization and other fixes #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
sphakka
commented
Apr 9, 2025
- qif: Correct handling of date format.
- csvtrim: much improved with CL options, detection of EOL and handling of partially broken CSV exports.
…zation with csvtrim Signed-off-by: Marco Emilio "sphakka" Poleggi <[email protected]>
Signed-off-by: Marco Emilio "sphakka" Poleggi <[email protected]>
…es. +output sorting Signed-off-by: Marco Emilio "sphakka" Poleggi <[email protected]>
…g txns predating the period's beginning Signed-off-by: Marco Emilio "sphakka" Poleggi <[email protected]>
Signed-off-by: Marco Emilio "sphakka" Poleggi <[email protected]>
Signed-off-by: Marco Emilio "sphakka" Poleggi <[email protected]>
|
As for the failing test "3.13, macos-latest", I guess that's due to some missing locales. Needed: fr_CH. Any advice? |
jaraco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this looks fine to me.
I'm not very familiar with csvtrim, and I sort-of feel like it should be moved to another project (or replaced with something like csvkit or miller). csvtrim appears to be bash-specific and thus minimally portable. That said, I can see that you've contributed to this utility before, and it only applies to this one mapping, so getting this code uncommented and fixed is useful. Let's proceed.
jaraco
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the ruff formatting error, but there are still failures in the tests for the mapping. Please fix.
Hi, thanks for all this. Actually, the failing test is on mapping 'n26', not my 'ubs-ch-fr'. I see it also on my local clone: I haven't touched m26 code and, sorry, have no idea about how to fix it -- my branch is ahead of upstream... As for 'csvtrim' (I'm the author), @reubano though of integrating it (#144) through 'meza' which is fine for me. Otherwise, it may be moved out of the code base. |