Main

[reutermj]

No description provided.

[Copilot]

Pull Request Overview

This PR centralizes the Windows SDK license acceptance check into the lazy-download step, adds parsing for the license-acceptance env var, and refactors a special-case toolchain naming prefix.

• Moved and simplified Windows SDK license check from cxx_toolchains into lazy_download_bins
• Parsed accept_winsdk_license from an env var in get_config_from_env_vars
• Refactored default toolchain naming logic in toolchains_cc.bzl

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
toolchains_cc.bzl	Removed commented-out Windows license block and refactored toolchain_name handling
impl/declare_tools.bzl	Added Windows SDK license acceptance check in _lazy_download_bins_impl
impl/config.bzl	Introduced accept_winsdk_license parsing from an env var in config

Comments suppressed due to low confidence (1)

impl/config.bzl:45

• [nitpick] New license-parsing logic should have unit tests verifying both True and False branches when the env var is set or unset.

    accept_winsdk_license_str = rctx.getenv(accept_winsdk_license_var)

[Copilot]

If toolchain_name is never passed in, it defaults to None, resulting in an env var named None_accept_winsdk_license. Consider defaulting toolchain_name to rctx.attr.toolchain_name or requiring it to be provided so the correct variable is read.