Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that libstdc++.so.6 is available by extracting the libstdc++6 package in addition to libstdc++-12-dev.
- Added download and extraction of
libstdc++6artifacts to the sysroot. - Ensured the missing
libstdc++.so.6symlink target is provided.
Comments suppressed due to low confidence (2)
impl/ubuntu.bzl:25
- The function’s docstring or comment should be updated to mention the new
libstdc++6extraction step so readers understand its full behavior.
def _extract_libstdcxx(rctx):
impl/ubuntu.bzl:31
- The URL references the
toolchains_ccrepo whereas the first extraction usestoolchains_cc.bzl; please verify and correct the repository path for consistency.
url = "https://github.com/reutermj/toolchains_cc/releases/download/binaries/libstdc++6_12.3.0-1ubuntu1.22.04_amd64.tar.xz",
| url = "https://github.com/reutermj/toolchains_cc.bzl/releases/download/binaries/libstdc++-12-dev_12.3.0-1ubuntu1.22.04_amd64.tar.xz", | ||
| output = "sysroot", | ||
| ) | ||
| rctx.download_and_extract( |
There was a problem hiding this comment.
[nitpick] Consider extracting the version string and base URL into constants to avoid duplication and simplify future updates.
libstdc++ was getting statically linked into the binary due to missing target of the symlink from libstdc++.so -> libstdc++.so.6. This was caused by missing a dependency `libstdc++6` of `libstdc++-12-dev`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libstdc++ was getting statically linked into the binary due to missing target of the symlink from libstdc++.so -> libstdc++.so.6. This was caused by missing a dependency
libstdc++6oflibstdc++-12-dev.