Enhance repro_dump output with start and end markers for clarity#8
Merged
Enhance repro_dump output with start and end markers for clarity#8
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the output of the repro_dump function by adding clear start and end markers to improve the build reproduction process.
- Added begin and end marker lines to the printed output
- Improved clarity of the reproduced configuration output
| def repro_dump(rctx, config): | ||
| # buildifier: disable=print | ||
| print(""" | ||
| --------============[[ Begin toolchains_cc repro dump ]]============-------- |
There was a problem hiding this comment.
[nitpick] The spacing within the marker text is inconsistent between the begin and end markers; consider aligning the spacing (e.g., using the same number of spaces before and after the text in the brackets) to improve consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.