This repository was archived by the owner on Apr 28, 2025. It is now read-only.
feat: Base plugin settings page, minor UI improvements and types#10
Open
feat: Base plugin settings page, minor UI improvements and types#10
Conversation
PalmDevs
reviewed
Jan 3, 2025
PalmDevs
reviewed
Jan 3, 2025
PalmDevs
reviewed
Jan 3, 2025
PalmDevs
suggested changes
Jan 3, 2025
Member
PalmDevs
left a comment
PalmDevs
left a comment
There was a problem hiding this comment.
A few changes and a commit are blocking
Ushie
suggested changes
Jan 6, 2025
Comment on lines
+46
to
+54
| style={{ marginBottom: 'auto' }} | ||
| /> | ||
| </Show> | ||
| <IconButton size="sm" icon={getAssetIndexByName('MoreHorizontalIcon')} variant="tertiary" /> | ||
| <IconButton | ||
| size="sm" | ||
| icon={getAssetIndexByName('MoreHorizontalIcon')} | ||
| variant="tertiary" | ||
| style={{ marginBottom: 'auto' }} | ||
| /> |
There was a problem hiding this comment.
Why is the margin-bottom needed here now?
Member
There was a problem hiding this comment.
Alignment issues when the plugin name takes >1 line, I might take a look into how to fix it by applying styles to the container instead of the children.
Ushie
changed the title
nexpid
requested review from
PalmDevs and
Ushie
and removed request for
PalmDevs
Contributor
Author
|
Is this thing on |
This comment was marked as abuse.
This comment was marked as abuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes:
__PYON_LOADER__types