Increased ITERATIONS in decrypt_email.js#647
Open
Linkan333 wants to merge 1 commit intorevertinc:mainfrom
Open
Increased ITERATIONS in decrypt_email.js#647Linkan333 wants to merge 1 commit intorevertinc:mainfrom
Linkan333 wants to merge 1 commit intorevertinc:mainfrom
Conversation
…will lower the performace this is not a must to add but could be good
|
@Linkan333 is attempting to deploy a commit to the Revert Team on Vercel. A member of the Team first needs to authorize it. |
|
Hey there and thank you for opening this pull request! 👋🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I increased the ITERATIONS variable in the decrypt_email.js file. This is because it could be usefull for Brute-Force Attacks to use PBKDF2 (Password-Bases Key Derivation Function 2). It could be bad for the performance on your website cause it will take longer time for each key to be generated.
For example at 100,000 iterations it might take ~100ms to derive a key. If you do the math with approximate 1 million password it would take ~27 hours on a single cpu to crack