ci: update workflows to use dorny/paths-filter#30
Merged
jinghao-jia merged 1 commit intomainfrom Apr 25, 2025
Merged
Conversation
Enabling **Require status checks to pass** can leave workflows un-triggered when GitHub’s built-in path filters decide nothing relevant changed, which in turn blocks PR merges because the required checks remain in the `Pending` state. Replace the native path filter with **dorny/paths-filter**: - The workflow is always triggered, satisfying the required-check. - Non-essential jobs are still skipped based on path rules, preventing resource waste. Signed-off-by: Ruowen Qin <ruowenq2@illinois.edu>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CI workflows to use the dorny/paths-filter action so that workflows always trigger while non-critical jobs are skipped based on file changes.
- Removed native paths-ignore filtering from workflows
- Added a new "changes" job that uses dorny/paths-filter for both meson and memcached_benchmark workflows
- Updated job dependencies to conditionally run based on the filtering outputs
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/rustfmt.yml | Removed paths-ignore configuration for triggering |
| .github/workflows/meson.yml | Introduced a changes job and conditionally run jobs |
| .github/workflows/memcached_benchmark.yml | Added a changes job and a redundant filter step in the build job |
Files not reviewed (1)
- .github/workflows/nix.yml: Language not supported
Comment on lines
+37
to
+42
| - id: filter | ||
| uses: dorny/paths-filter@v3 | ||
| with: | ||
| filters: | | ||
| bench: | ||
| - 'tools/memcached_benchmark/**' |
There was a problem hiding this comment.
The additional usage of dorny/paths-filter in the 'build' job appears redundant since the 'changes' job already provides the necessary filtering output. Consider removing this step to streamline workflow execution.
Suggested change
| - id: filter | |
| uses: dorny/paths-filter@v3 | |
| with: | |
| filters: | | |
| bench: | |
| - 'tools/memcached_benchmark/**' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabling Require status checks to pass can leave workflows un-triggered when GitHub’s built-in path filters decide nothing relevant changed, which in turn blocks PR merges because the required checks remain in the
Pendingstate.Replace the native path filter with dorny/paths-filter: