added -noxattr flag which ignores all xattr operations #987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Looks good beside the compile error |
rfjakob
requested changes
Jan 12, 2026
internal/fusefrontend/node_xattr.go
Outdated
| rn := n.rootNode() | ||
| // If -noxattr is enabled, return ENOATTR for all getxattr calls | ||
| if rn.args.NoXattr { | ||
| return 0, syscall.ENOATTR |
Contributor
Author
There was a problem hiding this comment.
fixed the issue, turned out that on Linux "no such attribute" is ENODATA while on Darwin it's ENOATTR
Owner
|
Merged, thanks! |
Owner
|
Bonus points by adding this to MANPAGE.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides huge speed improvements in macOS when accessing gocryptfs mounts backed by SMB/NFS, in particular over slow links:
Tested using directory with 333 files, shared over SMB from Ubuntu 24.04 server, accessed over high-latency link (5ms ping):
smb://myserver/MyVolumegocryptfs /Volumes/MyVolume mymountpointtime ls -l mymountpointrepeated 3 times.Without
-noxattr:65.35s, 89.23s, 68.93sWith
-noxattr:7.693s, 0.470s, 0.220sBrowsing latency in Finder is dramatically faster - going from "unusable" to "totally fine".