This repository was archived by the owner on Nov 13, 2023. It is now read-only.
Condense search window when there are fewer results#25
Open
kevinburke wants to merge 1 commit intorgarcia:masterfrom
Open
Condense search window when there are fewer results#25kevinburke wants to merge 1 commit intorgarcia:masterfrom
kevinburke wants to merge 1 commit intorgarcia:masterfrom
Conversation
Author
|
FYI: this also condenses the window in the full page view: https://skitch.com/kburke/en33e/dochub-instant-documentation-search Not sure how to get around that besides doing a check for the window size, or adding a media query. |
Author
|
This seems to also affect the menu dropdown in the black bar in condensed view, so it needs more work. |
Currently the search window in condensed view (narrower than 700px or so) takes up the entire height of the page, making it very difficult to scroll past as scrollbars are nested inside of each other. By changing the height to maxHeight, the search window will only take up the full page if there is more than a full page of search results. As the user filters the search options, the search window will shrink as well, displaying the results "above the fold". Screenshot: https://skitch.com/kburke/en32p/dochub-instant-documentation-search
neiesc
pushed a commit
to neiesc/dochub
that referenced
this pull request
Dec 19, 2013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the search window in condensed view (narrower than 700px or so) takes
up the entire height of the page, making it very difficult to scroll past as
scrollbars are nested inside of each other. By changing the height to
maxHeight, the search window will only take up the full page if there is more
than a full page of search results. As the user filters the search options, the
search window will shrink as well, displaying the results "above the fold".
Screenshot: https://skitch.com/kburke/en32p/dochub-instant-documentation-search