Fix: don't match enum columns as spatial #433
Conversation
| SpatialModel.lease_connection.create_enum(:point_type, ["point", "line_string", "polygon"]) | ||
| SpatialModel.lease_connection.create_table(:spatial_models, force: true) do |t| |
There was a problem hiding this comment.
Is it properly cleanup afterwards ? If so, how ?
There was a problem hiding this comment.
i don't know - i copied this from the other examples, can you point me to where any explicit cleanup happens?
| t.column "latlon", :st_point, srid: 3785 | ||
| t.column "latlon_geo", :st_point, srid: 4326, geographic: true | ||
| t.column "default_latlon", :st_point, srid: 0, default: "POINT(0.0 0.0)" |
There was a problem hiding this comment.
these were copied from create_model below, happy to remove them if you think it's necessary.
| @sql_type_metadata = sql_type_metadata | ||
| @geographic = !!(sql_type_metadata.sql_type =~ /geography\(/i) | ||
| if spatial | ||
| if sql_type_metadata.type == :enum |
There was a problem hiding this comment.
I feel like we should not be there if we are handling enums. Otherwise this also means that sql_type_metadata is set for every column, spatial or not.
I believe we should verify how the step before that one is working to make sure this is the correct place (e.g. who is initialising this)
There was a problem hiding this comment.
afaict this is by design.
this is initialized from #new_column_from_field which overrides the rails implementation and returns a SpatialColumn (instead of a PostgreSQL::Column) for all columns.
i'm not sure what would happen if some fields were one type and some were another but it seems out of scope for this pr.
2 participants
fixes #432