Skip to content

Comments

docs: fix typos and grammatical errors in Day 1 and Labs documentation#1754

Open
umutKaracelebi wants to merge 1 commit intorh-ecosystem-edge:mainfrom
umutKaracelebi:fix-docs-typos
Open

docs: fix typos and grammatical errors in Day 1 and Labs documentation#1754
umutKaracelebi wants to merge 1 commit intorh-ecosystem-edge:mainfrom
umutKaracelebi:fix-docs-typos

Conversation

@umutKaracelebi
Copy link

@umutKaracelebi umutKaracelebi commented Feb 19, 2026

This PR fixes several typos and grammatical errors identified in the documentation files to improve clarity and professionalism.

Changes:

  • docs/mkdocs/documentation/day1_limited_option.md:
    • Fixed typo "functionlity" to "functionality".
    • Fixed grammar error "an functional" to "a functional".
    • Fixed typo "opensfhit.io" to "openshift.io".
    • Fixed typo "targetting" to "targeting".
  • docs/mkdocs/labsv2.md:
    • Fixed typo "dependant" to "dependent".

No code or logic changes were made; only documentation files (.md) were updated.

Summary by CodeRabbit

  • Documentation
    • Resolved grammar and spelling inconsistencies across guides for improved readability
    • Corrected OpenShift MachineConfig label references to match proper technical specifications
    • Enhanced module loading documentation with additional example clarifying ordering behavior

@netlify
Copy link

netlify bot commented Feb 19, 2026

Deploy Preview for openshift-kmm ready!

Name Link
🔨 Latest commit 3aca0c3
🔍 Latest deploy log https://app.netlify.com/projects/openshift-kmm/deploys/69975f1762a7cf0009df7732
😎 Deploy Preview https://deploy-preview-1754--openshift-kmm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci
Copy link

openshift-ci bot commented Feb 19, 2026

Hi @umutKaracelebi. Thanks for your PR.

I'm waiting for a rh-ecosystem-edge member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai
Copy link

coderabbitai bot commented Feb 19, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

Documentation corrections including grammar fixes, OpenShift label reference corrections, spelling adjustments, and terminology clarifications across two documentation files.

Changes

Cohort / File(s) Summary
Grammar and Label Corrections
docs/mkdocs/documentation/day1_limited_option.md
Fixed grammatical error ("an functional" → "a functional"), corrected OpenShift MachineConfig label references from machineconfiguration.opensfhit.io/role to machineconfiguration.openshift.io/role for master and worker targets, and fixed typo ("targetting" → "targeting").
Spelling and Terminology Updates
docs/mkdocs/labsv2.md
Corrected spelling ("dependant modules" → "dependent modules") in soft dependencies section and added clarifying example note about Module loading order.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main purpose of the PR: fixing typos and grammatical errors in documentation files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@TomerNewman
Copy link
Member

/ok-to-test

@TomerNewman
Copy link
Member

@umutKaracelebi Thanks for your fix!
/approve
/assign @yevgeny-shnaidman @ybettan
/uncc @bthurber @chr15p
/cc @yevgeny-shnaidman @ybettan

@openshift-ci openshift-ci bot requested review from ybettan and yevgeny-shnaidman and removed request for bthurber and chr15p February 23, 2026 08:48
@openshift-ci
Copy link

openshift-ci bot commented Feb 23, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomerNewman, umutKaracelebi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yevgeny-shnaidman
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 23, 2026
@TomerNewman
Copy link
Member

/retest

1 similar comment
@umutKaracelebi
Copy link
Author

/retest

@umutKaracelebi
Copy link
Author

Hi,

The CI is persistently failing with an infrastructure error: NoClusters: No clusters in pool are ready to be claimed. It seems the rh-ecosystem-edge-4-17-cluster-pool is currently depleted or malfunctioning.

Since these are only documentation/typo fixes, could you please take a look at the CI status or manually trigger the tests once the cluster pool is restored?

/retest

@openshift-ci
Copy link

openshift-ci bot commented Feb 23, 2026

@umutKaracelebi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/operator-hub-upgrade 3aca0c3 link true /test operator-hub-upgrade
ci/prow/e2e 3aca0c3 link true /test e2e
ci/prow/e2e-hub 3aca0c3 link true /test e2e-hub
ci/prow/operator-upgrade 3aca0c3 link true /test operator-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants