Add new GH shellcheck action

[leo8a]

This PR adds a GH action that checks errors in shell scripts for every commit to main. As a complement, fixes to pass the shellcheck linter can be found in #397, #398, #399, #400, and #401.

Signed-off-by: Leo Ochoa lochoa@redhat.com

[leo8a]

/cc @alknopfler

[github-actions]

Thank you for making this first PR

[fbac]

Triggering the test-ci manually, we'll merge the PR once the test has passed.

[fbac]

LGTM.

Checks triggered.

[flaper87]

I have updated the branch just to make sure that all the latest changes pass the checks too.

/lgtm

[iranzo]

@leo8a sorry for the delay, but the pipe was not in shape for doing the testing.

We realized that with this PR in place, it breaks apparently the copy of some files and hence, the installation fails:

• https://github.com/rh-ecosystem-edge/ztp-pipeline-relocatable/runs/6857230029?check_suite_focus=true#step:5:734

This works fine on main branch.

I would suggest to split this into different PR's:

• One for the GHA for the checks
• One PR for each of the file changes, in that way, we run the pipe to see if it gets affected on that specific file and change without having to debug or rework on it as a whole

What do you think?

[leo8a]

Hey team, sure, no problem on my side.

You'll find fixes to pass the shellcheck linter on #397, #398, #399, #400, and #401. Once those are in place, I'll just update this to get in the GH action.

Cheers!

[fbac]

Thanks @leo8a! Rebasing the PR branch and testing again.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[iranzo]

LGTM for me, let's try to get the other stuff in and merge this