Skip to content

WIP MGMT-9754 Static IPs#586

Open
mareklibra wants to merge 29 commits intorh-ecosystem-edge:mainfrom
mareklibra:MGMT-9754.StaticIPs.BasedOn.MGMT-12274.StatelessUI
Open

WIP MGMT-9754 Static IPs#586
mareklibra wants to merge 29 commits intorh-ecosystem-edge:mainfrom
mareklibra:MGMT-9754.StaticIPs.BasedOn.MGMT-12274.StatelessUI

Conversation

@mareklibra
Copy link
Collaborator

@mareklibra mareklibra commented Nov 2, 2022

Depends on (needs rebase):

Replaces:

Description

Provides UI to configure static IPs via NMState.
Fixes # (issue)

Type of change

Please select the appropriate options:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change is a documentation update

Testing

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Versions:
  • Hardware:

Checklist

  • I have performed a self-review of my own code
  • If a change is adding a feature, it should require a change to the README.md and the review should catch this.
  • If the change is a fix, it should have an issue. The review should make sure the comments state the issue (not just the number) and it should use the keywords that will close the issue on merge.
  • A change should not be merged unless it passes CI or there is a comment/update saying what testing was passed.
  • PRs should not be merged unless positively reviewed.

@github-actions github-actions bot added test-ci-ui Force run UI test ui labels Nov 2, 2022
@mareklibra mareklibra added the Hold Dont merge this yet! label Nov 3, 2022
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hold Dont merge this yet! needs rebase size/XXL test-ci-ui Force run UI test ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant