Skip to content

Conversation

Josh-Matsuoka
Copy link
Contributor

@Josh-Matsuoka Josh-Matsuoka commented Jul 4, 2024

Hi,

This PR fixes OPENJDK-2903, adding a mandatory template parameter (APPNAME) that ensures all created resources are uniquely named.

https://issues.redhat.com/browse/OPENJDK-2903

are uniquely named.

Related: OPENJDK-2903
@Josh-Matsuoka Josh-Matsuoka requested a review from jmtd July 4, 2024 13:02
@Josh-Matsuoka Josh-Matsuoka self-assigned this Jul 4, 2024
@jmtd jmtd changed the title Ensure created objects are uniquely named [OPENJDK-2903] [jlink] Ensure created objects are uniquely named Oct 8, 2024
Copy link
Member

@jmtd jmtd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, thanks!

There are a couple of references to the ImageStream ubimicro:latest which need updating to be prefixed with the template variable.

@jmtd
Copy link
Member

jmtd commented Oct 21, 2024

@Josh-Matsuoka please add reference to APPNAME in templates/jlink/README.md too!

@jmtd jmtd merged commit 3dd45b2 into rh-openjdk:jlink-dev Oct 22, 2024
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants